fix(vite): resolves files with dot suffixes correctly #28518
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Your CI Pipeline Execution ↗ for commit 1cbeed5 ✅ succeeded.
Last updated at 2024-12-12 20:07:08UTC Sent with 💌 from NxCloud. |
|
There is some regression. I'm fixing... |
|
I'm not sure 100%, but I think there was a mistake here when creating the file |
|
Hello, nx team. Could you provide some feedback about this PR, we really need this fix in our project. I will appreciate this |
|
same here, need this regression fixed 👍 |
|
Same here! Wondering if this fix will land in the next release :) |
|
Sorry to bug again but this issue is still preventing us from being able to upgrade Nx! |
|
yep, we are on 20.2.2, and this is been a regression since 19.6.6+ |
concat `ext` with `filename` for parse in `findFile` function from `nx-tsconfig-paths.plugin` that previously led to an unresolved error for files with dot suffixes e.g.`/dir/file.suffix.ext` Closes nrwl#27852
use basename & dirname in findFile method from nx-tsconfig-paths.plugin
use replace only once per function in nx-tsconfig-paths-find-file
|
@KonstantinKai @roshcagra @dvictory This has been merged now and should release in a patch soon |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Use
basenamefor retrieving the filename infindFilefunction fromnx-tsconfig-paths.pluginthat previously led to an unresolved error for files with dot suffixes e.g./dir/file.suffix.extCurrent Behavior
For files that have the same name but one of them has a suffix, e.g.
The resolving process is incorrect because the
import value from '@lib1/file.i18n'fromapps/app1/main.tsevery time resolves tofile.ts,and theparsemethod from thenode:pathsplits away the suffix from the name.Expected Behavior
import value from '@lib1/file.i18n'should work correctly if you import them from another packageRelated Issue(s)
Fixes #27852